Closed
Conversation
nodejs-github-bot
added
doc
Contributor
Author
Contributor
Author
danbev
requested review from
eljefedelrodeodeljefe
and removed request for
eljefedelrodeodeljefe
Contributor
Author
|
Another CI for lint fixes: https://ci.nodejs.org/job/node-test-pull-request/8941/ |
Contributor
Author
|
@Trott Would you be able to give this a review? I'm heading off on PTO after tomorrow and would like to try to address anything before that. Thanks |
Member
|
Hoping to enlist a quick review or two from folks with a lot of lines authored in the modified files: @indutny @rvagg @eljefedelrodeodeljefe @jasnell |
danbev
force-pushed
the
fix-addon-verify.js
branch
from
0f761ab to
ee2db0e
Compare
Contributor
Author
Member
|
@nodejs/collaborators This could use some reviews. |
The current implementation of addon-verify.js is including the code for the "Function arguments" section in test/addons/01_callbacks and there is no directory generated or the "Function arguments section". This continues and leads to the last section, "AtExit", code to be excluded. There is an test/addons/07_atexit_hooks but it contains code from the "Passing wrapped objects around" section. This commit modifies addon-verify to associate headers with code and then iterates over the set and generates the files as a separate step.
When working on commit 0d95a0b ("test: remove undef NDEBUG from at-exit addons test) I searched for usages of undef NDEBUG but did not include the doc directory (but I did include the test directory) and missed this one. Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix tools/addon-verify.js") enables the code in the "AtExit" section to be included in the test/addons diretory and this code will again be tested.
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed.
danbev
force-pushed
the
fix-addon-verify.js
branch
from
ee2db0e to
3731f60
Compare
Contributor
Author
|
If anyone has time to give this a review it would be much appreciated. |
targos
approved these changes
Aug 9, 2017
Contributor
Author
|
@targos Thanks! |
Member
|
|
danbev
added a commit
to danbev/node
that referenced
this pull request
Aug 10, 2017
The current implementation of addon-verify.js is including the code for the "Function arguments" section in test/addons/01_callbacks and there is no directory generated or the "Function arguments section". This continues and leads to the last section, "AtExit", code to be excluded. There is an test/addons/07_atexit_hooks but it contains code from the "Passing wrapped objects around" section. This commit modifies addon-verify to associate headers with code and then iterates over the set and generates the files as a separate step. PR-URL: nodejs#14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
danbev
added a commit
to danbev/node
that referenced
this pull request
Aug 10, 2017
When working on commit 0d95a0b ("test: remove undef NDEBUG from at-exit addons test) I searched for usages of undef NDEBUG but did not include the doc directory (but I did include the test directory) and missed this one. Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix tools/addon-verify.js") enables the code in the "AtExit" section to be included in the test/addons diretory and this code will again be tested. PR-URL: nodejs#14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
danbev
added a commit
to danbev/node
that referenced
this pull request
Aug 10, 2017
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed. PR-URL: nodejs#14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Contributor
Author
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
The current implementation of addon-verify.js is including the code for the "Function arguments" section in test/addons/01_callbacks and there is no directory generated or the "Function arguments section". This continues and leads to the last section, "AtExit", code to be excluded. There is an test/addons/07_atexit_hooks but it contains code from the "Passing wrapped objects around" section. This commit modifies addon-verify to associate headers with code and then iterates over the set and generates the files as a separate step. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
When working on commit 0d95a0b ("test: remove undef NDEBUG from at-exit addons test) I searched for usages of undef NDEBUG but did not include the doc directory (but I did include the test directory) and missed this one. Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix tools/addon-verify.js") enables the code in the "AtExit" section to be included in the test/addons diretory and this code will again be tested. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
refack
added
build
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
When working on commit 0d95a0b ("test: remove undef NDEBUG from at-exit addons test) I searched for usages of undef NDEBUG but did not include the doc directory (but I did include the test directory) and missed this one. Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix tools/addon-verify.js") enables the code in the "AtExit" section to be included in the test/addons diretory and this code will again be tested. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
The current implementation of addon-verify.js is including the code for the "Function arguments" section in test/addons/01_callbacks and there is no directory generated or the "Function arguments section". This continues and leads to the last section, "AtExit", code to be excluded. There is an test/addons/07_atexit_hooks but it contains code from the "Passing wrapped objects around" section. This commit modifies addon-verify to associate headers with code and then iterates over the set and generates the files as a separate step. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of addon-verify.js is including the code
for the "Function arguments" section in test/addons/01_callbacks and
there is no directory generated or the "Function arguments section".
This continues and leads to the last section, "AtExit", code to be
excluded. There is an test/addons/07_atexit_hooks but it contains code
from the "Passing wrapped objects around" section.
This commit modifies addon-verify to associate headers with code and
then iterates over the set and generates the files as a separate step.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools, test